Message ID | 1459426558-23423-1-git-send-email-zhe.tao@intel.com (mailing list archive) |
---|---|
State | Changes Requested, archived |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 5D4C16CA1; Thu, 31 Mar 2016 14:16:07 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 826146C9C for <dev@dpdk.org>; Thu, 31 Mar 2016 14:16:05 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP; 31 Mar 2016 05:16:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,422,1455004800"; d="scan'208";a="922551989" Received: from shvmail01.sh.intel.com ([10.239.29.42]) by orsmga001.jf.intel.com with ESMTP; 31 Mar 2016 05:16:03 -0700 Received: from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com [10.239.29.89]) by shvmail01.sh.intel.com with ESMTP id u2VCG1bW028597; Thu, 31 Mar 2016 20:16:01 +0800 Received: from shecgisg004.sh.intel.com (localhost [127.0.0.1]) by shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP id u2VCFw6J023457; Thu, 31 Mar 2016 20:16:00 +0800 Received: (from zhetao@localhost) by shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id u2VCFw97023453; Thu, 31 Mar 2016 20:15:58 +0800 From: Zhe Tao <zhe.tao@intel.com> To: dev@dpdk.org Cc: zhe.tao@intel.com, jingjing.wu@intel.com Date: Thu, 31 Mar 2016 20:15:58 +0800 Message-Id: <1459426558-23423-1-git-send-email-zhe.tao@intel.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1458703670-19898-1-git-send-email-zhe.tao@intel.com> References: <1458703670-19898-1-git-send-email-zhe.tao@intel.com> Subject: [dpdk-dev] [PATCH v3] i40e: fix TSO issue for tx function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
Zhe Tao
March 31, 2016, 12:15 p.m. UTC
Issue: when using the following CLI in testpmd to enable ipv6 TSO feature (set --txqflags=0 in the testpmd command) set verbose 1 csum set ip hw 0 csum set udp hw 0 csum set tcp hw 0 csum set sctp hw 0 csum set outer-ip hw 0 csum parse_tunnel on 0 tso set 800 0 set fwd csum start We will not get what we want, the ipv6 packets sent out from IXIA can be received by i40e, but cannot forward to another port. The root cause is when HW doing the TSO offload for packets, it does not only depends on the context descriptor to define the MSS and TSO payload size, it also need to know whether this packets is ipv4 or ipv6, we use i40e_txd_enable_checksum to generate the related fields for data descriptor. But PMD will not call i40e_txd_enable_checksum if only the TSO offload flag is set. The reason why ipv4 works fine for TSO in testpmd csum mode is csum engine will set the ip csum flag when the packet is ipv4 and TSO is enabled but will not set the flag for ipv6 and this flag will cause the i40e_txd_enable_checksum to be invoked. For both the cases the TSO flag will be set, so we need to use TSO flag to trigger the i40e_txd_enable_checksum. The right logic here is we enable csum offload for both ipv4 and ipv6 when TSO flag is set. Fixes: e3f0151f (i40e: enable Tx checksum only for offloaded packets) --- drivers/net/i40e/i40e_rxtx.c | 1 + 1 file changed, 1 insertion(+)
Comments
On Thu, Mar 31, 2016 at 08:15:58PM +0800, Zhe Tao wrote: > Issue: > > when using the following CLI in testpmd to enable ipv6 TSO feature > (set --txqflags=0 in the testpmd command) > set verbose 1 > csum set ip hw 0 > csum set udp hw 0 > csum set tcp hw 0 > csum set sctp hw 0 > csum set outer-ip hw 0 > csum parse_tunnel on 0 > tso set 800 0 > set fwd csum > start > > We will not get what we want, the ipv6 packets sent out from IXIA can be > received by i40e, but cannot forward to another port. > The root cause is when HW doing the TSO offload for packets, it does not only > depends on the context descriptor to define the MSS and TSO payload size, it > also need to know whether this packets is ipv4 or ipv6, we use > i40e_txd_enable_checksum to generate the related fields for data descriptor. > But PMD will not call i40e_txd_enable_checksum if only the TSO offload flag is > set. The reason why ipv4 works fine for TSO in testpmd csum mode is csum engine > will set the ip csum flag when the packet is ipv4 and TSO is enabled but > will not set the flag for ipv6 and this flag will cause the > i40e_txd_enable_checksum to be invoked. For both the cases the TSO flag will be > set, so we need to use TSO flag to trigger the i40e_txd_enable_checksum. > The right logic here is we enable csum offload for both ipv4 and ipv6 when TSO > flag is set. > > Fixes: e3f0151f (i40e: enable Tx checksum only for offloaded packets) Missing sign-off in this version. > --- > drivers/net/i40e/i40e_rxtx.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c > index 81cde6c..6e3fd25 100644 > --- a/drivers/net/i40e/i40e_rxtx.c > +++ b/drivers/net/i40e/i40e_rxtx.c > @@ -76,6 +76,7 @@ > #define I40E_TX_CKSUM_OFFLOAD_MASK ( \ > PKT_TX_IP_CKSUM | \ > PKT_TX_L4_MASK | \ > + PKT_TX_TCP_SEG | \ > PKT_TX_OUTER_IP_CKSUM) > > static uint16_t i40e_xmit_pkts_simple(void *tx_queue, > -- > v2: changed condition check for ipv6 TSO checksum offload > use a more clear check method which include both ipv4 & ipv6 TSO > v3: edited the commit log and title because this problem exists for both > ipv4 and ipv6 > 2.1.4 > This version history is clearer when placed immediately below the commit description. You also need to use a 3-character cut-line, rather than 2-char, in that case. /Bruce
diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c index 81cde6c..6e3fd25 100644 --- a/drivers/net/i40e/i40e_rxtx.c +++ b/drivers/net/i40e/i40e_rxtx.c @@ -76,6 +76,7 @@ #define I40E_TX_CKSUM_OFFLOAD_MASK ( \ PKT_TX_IP_CKSUM | \ PKT_TX_L4_MASK | \ + PKT_TX_TCP_SEG | \ PKT_TX_OUTER_IP_CKSUM) static uint16_t i40e_xmit_pkts_simple(void *tx_queue,