[dpdk-dev] doc: fill nics features matrix for mlx4 & mlx5

Message ID 1459419757-20487-1-git-send-email-adrien.mazarguil@6wind.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Adrien Mazarguil March 31, 2016, 10:22 a.m. UTC
  Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
---
 doc/guides/nics/overview.rst | 56 ++++++++++++++++++++++----------------------
 1 file changed, 28 insertions(+), 28 deletions(-)
  

Comments

Jianfeng Tan March 31, 2016, 10:55 a.m. UTC | #1
Hi,

On 3/31/2016 6:22 PM, Adrien Mazarguil wrote:
> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> ---
>   doc/guides/nics/overview.rst | 56 ++++++++++++++++++++++----------------------
>   1 file changed, 28 insertions(+), 28 deletions(-)
>
> diff --git a/doc/guides/nics/overview.rst b/doc/guides/nics/overview.rst
> index 542479a..5238088 100644
> --- a/doc/guides/nics/overview.rst
> +++ b/doc/guides/nics/overview.rst
> @@ -86,63 +86,63 @@ Most of these differences are summarized below.
>                                             e   e       e   e   e                     e
>                                             c   c       c   c   c                     c
>      ==================== = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = =
> -   link status                  X       X X                                   X X
> -   link status event                    X X                                     X
> +   link status                  X       X X                     X X           X X
> +   link status event                    X X                     X X             X
>      queue status event                                                           X
>      Rx interrupt                         X X X X
> -   queue start/stop             X   X   X X X X                               X
> -   MTU update                   X   X
> -   jumbo frame                  X   X   X X X X
> -   scattered Rx                 X   X   X X X X                               X
> +   queue start/stop             X   X   X X X X                 X X           X
> +   MTU update                   X   X                           X X
> +   jumbo frame                  X   X   X X X X                 X X
> +   scattered Rx                 X   X   X X X X                 X X           X
>      LRO
>      TSO                          X   X   X X X X
> -   promiscuous mode             X       X X X X                               X
> -   allmulticast mode            X       X X X X                               X
> +   promiscuous mode             X       X X X X                 X X           X
> +   allmulticast mode            X       X X X X                 X X           X
>      unicast MAC filter                   X X X X
>      multicast MAC filter                 X X X X
> -   RSS hash                     X   X   X X X X
> -   RSS key update                   X   X X X X
> -   RSS reta update                  X   X X X X
> +   RSS hash                     X   X   X X X X                 X X
> +   RSS key update                   X   X X X X                   X
> +   RSS reta update                  X   X X X X                   X
>      VMDq                                 X X
> -   SR-IOV                           X   X X
> +   SR-IOV                           X   X X                     X X
>      DCB                                  X X
> -   VLAN filter                          X X X X
> +   VLAN filter                          X X X X                 X X
>      ethertype filter                     X X
>      n-tuple filter
>      SYN filter
>      tunnel filter                        X X
>      flexible filter
>      hash filter                          X X X X
> -   flow director                        X X
> +   flow director                        X X                       X
>      flow control                 X       X X
>      rate limitation
>      traffic mirroring                    X X
> -   CRC offload                  X   X   X   X
> -   VLAN offload                 X   X   X   X
> +   CRC offload                  X   X   X   X                     X
> +   VLAN offload                 X   X   X   X                     X
>      QinQ offload                         X   X
> -   L3 checksum offload          X   X   X   X
> -   L4 checksum offload          X   X   X   X
> -   inner L3 checksum                X   X   X
> -   inner L4 checksum                X   X   X
> -   packet type parsing          X       X   X
> +   L3 checksum offload          X   X   X   X                   X X
> +   L4 checksum offload          X   X   X   X                   X X
> +   inner L3 checksum                X   X   X                   X
> +   inner L4 checksum                X   X   X                   X
> +   packet type parsing          X       X   X                   X X
>      timesync                             X X
> -   basic stats                  X   X   X X X X                               X X
> +   basic stats                  X   X   X X X X                 X X           X X
>      extended stats                   X   X X X X
> -   stats per queue              X                                             X
> +   stats per queue              X                               X X           X
>      EEPROM dump
>      registers dump
> -   multiprocess aware                   X X X X
> +   multiprocess aware                   X X X X                 X X
>      BSD nic_uio                  X       X X X X
>      Linux UIO                    X   X   X X X X
>      Linux VFIO                   X       X X X X
>      other kdrv                                                                 X
>      ARMv7
>      ARMv8
> -   Power8
> +   Power8                                                       X X
>      TILE-Gx
> -   x86-32                       X   X   X X X X                                 X
> -   x86-64                       X   X   X X X X                               X X
> -   usage doc                    X                                             X
> +   x86-32                       X   X   X X X X                 X X             X
> +   x86-64                       X   X   X X X X                 X X           X X
> +   usage doc                    X                               X X           X
>      design doc
>      perf doc
>      ==================== = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = =

Here "X" means "support"?

Thanks,
Jianfeng
  
Adrien Mazarguil March 31, 2016, 11 a.m. UTC | #2
On Thu, Mar 31, 2016 at 06:55:41PM +0800, Tan, Jianfeng wrote:
> Hi,
> 
> On 3/31/2016 6:22 PM, Adrien Mazarguil wrote:
> >Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> >---
> >  doc/guides/nics/overview.rst | 56 ++++++++++++++++++++++----------------------
> >  1 file changed, 28 insertions(+), 28 deletions(-)
> >
> >diff --git a/doc/guides/nics/overview.rst b/doc/guides/nics/overview.rst
> >index 542479a..5238088 100644
> >--- a/doc/guides/nics/overview.rst
> >+++ b/doc/guides/nics/overview.rst
> >@@ -86,63 +86,63 @@ Most of these differences are summarized below.
> >                                            e   e       e   e   e                     e
> >                                            c   c       c   c   c                     c
> >     ==================== = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = =
> >-   link status                  X       X X                                   X X
> >-   link status event                    X X                                     X
> >+   link status                  X       X X                     X X           X X
> >+   link status event                    X X                     X X             X
> >     queue status event                                                           X
> >     Rx interrupt                         X X X X
> >-   queue start/stop             X   X   X X X X                               X
> >-   MTU update                   X   X
> >-   jumbo frame                  X   X   X X X X
> >-   scattered Rx                 X   X   X X X X                               X
> >+   queue start/stop             X   X   X X X X                 X X           X
> >+   MTU update                   X   X                           X X
> >+   jumbo frame                  X   X   X X X X                 X X
> >+   scattered Rx                 X   X   X X X X                 X X           X
> >     LRO
> >     TSO                          X   X   X X X X
> >-   promiscuous mode             X       X X X X                               X
> >-   allmulticast mode            X       X X X X                               X
> >+   promiscuous mode             X       X X X X                 X X           X
> >+   allmulticast mode            X       X X X X                 X X           X
> >     unicast MAC filter                   X X X X
> >     multicast MAC filter                 X X X X
> >-   RSS hash                     X   X   X X X X
> >-   RSS key update                   X   X X X X
> >-   RSS reta update                  X   X X X X
> >+   RSS hash                     X   X   X X X X                 X X
> >+   RSS key update                   X   X X X X                   X
> >+   RSS reta update                  X   X X X X                   X
> >     VMDq                                 X X
> >-   SR-IOV                           X   X X
> >+   SR-IOV                           X   X X                     X X
> >     DCB                                  X X
> >-   VLAN filter                          X X X X
> >+   VLAN filter                          X X X X                 X X
> >     ethertype filter                     X X
> >     n-tuple filter
> >     SYN filter
> >     tunnel filter                        X X
> >     flexible filter
> >     hash filter                          X X X X
> >-   flow director                        X X
> >+   flow director                        X X                       X
> >     flow control                 X       X X
> >     rate limitation
> >     traffic mirroring                    X X
> >-   CRC offload                  X   X   X   X
> >-   VLAN offload                 X   X   X   X
> >+   CRC offload                  X   X   X   X                     X
> >+   VLAN offload                 X   X   X   X                     X
> >     QinQ offload                         X   X
> >-   L3 checksum offload          X   X   X   X
> >-   L4 checksum offload          X   X   X   X
> >-   inner L3 checksum                X   X   X
> >-   inner L4 checksum                X   X   X
> >-   packet type parsing          X       X   X
> >+   L3 checksum offload          X   X   X   X                   X X
> >+   L4 checksum offload          X   X   X   X                   X X
> >+   inner L3 checksum                X   X   X                   X
> >+   inner L4 checksum                X   X   X                   X
> >+   packet type parsing          X       X   X                   X X
> >     timesync                             X X
> >-   basic stats                  X   X   X X X X                               X X
> >+   basic stats                  X   X   X X X X                 X X           X X
> >     extended stats                   X   X X X X
> >-   stats per queue              X                                             X
> >+   stats per queue              X                               X X           X
> >     EEPROM dump
> >     registers dump
> >-   multiprocess aware                   X X X X
> >+   multiprocess aware                   X X X X                 X X
> >     BSD nic_uio                  X       X X X X
> >     Linux UIO                    X   X   X X X X
> >     Linux VFIO                   X       X X X X
> >     other kdrv                                                                 X
> >     ARMv7
> >     ARMv8
> >-   Power8
> >+   Power8                                                       X X
> >     TILE-Gx
> >-   x86-32                       X   X   X X X X                                 X
> >-   x86-64                       X   X   X X X X                               X X
> >-   usage doc                    X                                             X
> >+   x86-32                       X   X   X X X X                 X X             X
> >+   x86-64                       X   X   X X X X                 X X           X X
> >+   usage doc                    X                               X X           X
> >     design doc
> >     perf doc
> >     ==================== = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = =
> 
> Here "X" means "support"?

Erm, I must say I did not consider it could mean something else, I guess it
does?

Perhaps a few features could use a character other than "X" when additional
details are necessary (for instance incomplete features).
  
Jianfeng Tan March 31, 2016, 12:50 p.m. UTC | #3
Hi,

On 3/31/2016 7:00 PM, Adrien Mazarguil wrote:
> On Thu, Mar 31, 2016 at 06:55:41PM +0800, Tan, Jianfeng wrote:
>> Hi,
>>
>> On 3/31/2016 6:22 PM, Adrien Mazarguil wrote:
>>> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
>>> ---
>>>   doc/guides/nics/overview.rst | 56 ++++++++++++++++++++++----------------------
>>>   1 file changed, 28 insertions(+), 28 deletions(-)
>>>
>>> diff --git a/doc/guides/nics/overview.rst b/doc/guides/nics/overview.rst
>>> index 542479a..5238088 100644
>>> --- a/doc/guides/nics/overview.rst
>>> +++ b/doc/guides/nics/overview.rst
>>> @@ -86,63 +86,63 @@ Most of these differences are summarized below.
>>>                                             e   e       e   e   e                     e
>>>                                             c   c       c   c   c                     c
>>>      ==================== = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = =
>>> -   link status                  X       X X                                   X X
>>> -   link status event                    X X                                     X
>>> +   link status                  X       X X                     X X           X X
>>> +   link status event                    X X                     X X             X
>>>      queue status event                                                           X
>>>      Rx interrupt                         X X X X
>>> -   queue start/stop             X   X   X X X X                               X
>>> -   MTU update                   X   X
>>> -   jumbo frame                  X   X   X X X X
>>> -   scattered Rx                 X   X   X X X X                               X
>>> +   queue start/stop             X   X   X X X X                 X X           X
>>> +   MTU update                   X   X                           X X
>>> +   jumbo frame                  X   X   X X X X                 X X
>>> +   scattered Rx                 X   X   X X X X                 X X           X
>>>      LRO
>>>      TSO                          X   X   X X X X
>>> -   promiscuous mode             X       X X X X                               X
>>> -   allmulticast mode            X       X X X X                               X
>>> +   promiscuous mode             X       X X X X                 X X           X
>>> +   allmulticast mode            X       X X X X                 X X           X
>>>      unicast MAC filter                   X X X X
>>>      multicast MAC filter                 X X X X
>>> -   RSS hash                     X   X   X X X X
>>> -   RSS key update                   X   X X X X
>>> -   RSS reta update                  X   X X X X
>>> +   RSS hash                     X   X   X X X X                 X X
>>> +   RSS key update                   X   X X X X                   X
>>> +   RSS reta update                  X   X X X X                   X
>>>      VMDq                                 X X
>>> -   SR-IOV                           X   X X
>>> +   SR-IOV                           X   X X                     X X
>>>      DCB                                  X X
>>> -   VLAN filter                          X X X X
>>> +   VLAN filter                          X X X X                 X X
>>>      ethertype filter                     X X
>>>      n-tuple filter
>>>      SYN filter
>>>      tunnel filter                        X X
>>>      flexible filter
>>>      hash filter                          X X X X
>>> -   flow director                        X X
>>> +   flow director                        X X                       X
>>>      flow control                 X       X X
>>>      rate limitation
>>>      traffic mirroring                    X X
>>> -   CRC offload                  X   X   X   X
>>> -   VLAN offload                 X   X   X   X
>>> +   CRC offload                  X   X   X   X                     X
>>> +   VLAN offload                 X   X   X   X                     X
>>>      QinQ offload                         X   X
>>> -   L3 checksum offload          X   X   X   X
>>> -   L4 checksum offload          X   X   X   X
>>> -   inner L3 checksum                X   X   X
>>> -   inner L4 checksum                X   X   X
>>> -   packet type parsing          X       X   X
>>> +   L3 checksum offload          X   X   X   X                   X X
>>> +   L4 checksum offload          X   X   X   X                   X X
>>> +   inner L3 checksum                X   X   X                   X
>>> +   inner L4 checksum                X   X   X                   X
>>> +   packet type parsing          X       X   X                   X X
>>>      timesync                             X X
>>> -   basic stats                  X   X   X X X X                               X X
>>> +   basic stats                  X   X   X X X X                 X X           X X
>>>      extended stats                   X   X X X X
>>> -   stats per queue              X                                             X
>>> +   stats per queue              X                               X X           X
>>>      EEPROM dump
>>>      registers dump
>>> -   multiprocess aware                   X X X X
>>> +   multiprocess aware                   X X X X                 X X
>>>      BSD nic_uio                  X       X X X X
>>>      Linux UIO                    X   X   X X X X
>>>      Linux VFIO                   X       X X X X
>>>      other kdrv                                                                 X
>>>      ARMv7
>>>      ARMv8
>>> -   Power8
>>> +   Power8                                                       X X
>>>      TILE-Gx
>>> -   x86-32                       X   X   X X X X                                 X
>>> -   x86-64                       X   X   X X X X                               X X
>>> -   usage doc                    X                                             X
>>> +   x86-32                       X   X   X X X X                 X X             X
>>> +   x86-64                       X   X   X X X X                 X X           X X
>>> +   usage doc                    X                               X X           X
>>>      design doc
>>>      perf doc
>>>      ==================== = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = =
>> Here "X" means "support"?
> Erm, I must say I did not consider it could mean something else, I guess it
> does?
>
> Perhaps a few features could use a character other than "X" when additional
> details are necessary (for instance incomplete features).
>

Thanks for explanation. I was wrongly treating "X" as "not supported" 
previously. I was looking at "TSO", and it indicates by the table that 
ixgbe does not support TSO, which does not make sense to me. Or this doc 
is not updated efficiently?
  
Thomas Monjalon March 31, 2016, 12:55 p.m. UTC | #4
2016-03-31 20:50, Tan, Jianfeng:
> Thanks for explanation. I was wrongly treating "X" as "not supported" 
> previously. I was looking at "TSO", and it indicates by the table that 
> ixgbe does not support TSO, which does not make sense to me. Or this doc 
> is not updated efficiently?

According to the table, ixgbe supports nothing.
Does it mean this driver is useless? If so we could remove it ;)
Or you can talk to the maintainers of the driver to ask an update.
Thanks for pointing it
  
Thomas Monjalon April 1, 2016, 9:47 p.m. UTC | #5
> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

Applied, thanks
  

Patch

diff --git a/doc/guides/nics/overview.rst b/doc/guides/nics/overview.rst
index 542479a..5238088 100644
--- a/doc/guides/nics/overview.rst
+++ b/doc/guides/nics/overview.rst
@@ -86,63 +86,63 @@  Most of these differences are summarized below.
                                           e   e       e   e   e                     e
                                           c   c       c   c   c                     c
    ==================== = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = =
-   link status                  X       X X                                   X X
-   link status event                    X X                                     X
+   link status                  X       X X                     X X           X X
+   link status event                    X X                     X X             X
    queue status event                                                           X
    Rx interrupt                         X X X X
-   queue start/stop             X   X   X X X X                               X
-   MTU update                   X   X
-   jumbo frame                  X   X   X X X X
-   scattered Rx                 X   X   X X X X                               X
+   queue start/stop             X   X   X X X X                 X X           X
+   MTU update                   X   X                           X X
+   jumbo frame                  X   X   X X X X                 X X
+   scattered Rx                 X   X   X X X X                 X X           X
    LRO
    TSO                          X   X   X X X X
-   promiscuous mode             X       X X X X                               X
-   allmulticast mode            X       X X X X                               X
+   promiscuous mode             X       X X X X                 X X           X
+   allmulticast mode            X       X X X X                 X X           X
    unicast MAC filter                   X X X X
    multicast MAC filter                 X X X X
-   RSS hash                     X   X   X X X X
-   RSS key update                   X   X X X X
-   RSS reta update                  X   X X X X
+   RSS hash                     X   X   X X X X                 X X
+   RSS key update                   X   X X X X                   X
+   RSS reta update                  X   X X X X                   X
    VMDq                                 X X
-   SR-IOV                           X   X X
+   SR-IOV                           X   X X                     X X
    DCB                                  X X
-   VLAN filter                          X X X X
+   VLAN filter                          X X X X                 X X
    ethertype filter                     X X
    n-tuple filter
    SYN filter
    tunnel filter                        X X
    flexible filter
    hash filter                          X X X X
-   flow director                        X X
+   flow director                        X X                       X
    flow control                 X       X X
    rate limitation
    traffic mirroring                    X X
-   CRC offload                  X   X   X   X
-   VLAN offload                 X   X   X   X
+   CRC offload                  X   X   X   X                     X
+   VLAN offload                 X   X   X   X                     X
    QinQ offload                         X   X
-   L3 checksum offload          X   X   X   X
-   L4 checksum offload          X   X   X   X
-   inner L3 checksum                X   X   X
-   inner L4 checksum                X   X   X
-   packet type parsing          X       X   X
+   L3 checksum offload          X   X   X   X                   X X
+   L4 checksum offload          X   X   X   X                   X X
+   inner L3 checksum                X   X   X                   X
+   inner L4 checksum                X   X   X                   X
+   packet type parsing          X       X   X                   X X
    timesync                             X X
-   basic stats                  X   X   X X X X                               X X
+   basic stats                  X   X   X X X X                 X X           X X
    extended stats                   X   X X X X
-   stats per queue              X                                             X
+   stats per queue              X                               X X           X
    EEPROM dump
    registers dump
-   multiprocess aware                   X X X X
+   multiprocess aware                   X X X X                 X X
    BSD nic_uio                  X       X X X X
    Linux UIO                    X   X   X X X X
    Linux VFIO                   X       X X X X
    other kdrv                                                                 X
    ARMv7
    ARMv8
-   Power8
+   Power8                                                       X X
    TILE-Gx
-   x86-32                       X   X   X X X X                                 X
-   x86-64                       X   X   X X X X                               X X
-   usage doc                    X                                             X
+   x86-32                       X   X   X X X X                 X X             X
+   x86-64                       X   X   X X X X                 X X           X X
+   usage doc                    X                               X X           X
    design doc
    perf doc
    ==================== = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = = =