diff mbox

[dpdk-dev,v2] mlx5: fix RETA table size

Message ID 1459416068-11773-1-git-send-email-yaacovh@mellanox.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Yaacov Hazan March 31, 2016, 9:21 a.m. UTC 
  When the number of RX queues is not a power of two,
the RETA table is configured to its maximum size for
better balancing.

Testing showed that limiting its size to 256 improves performance
noticeably with little to no  impact on balancing results.

Fixes: ebb30ec64a68 ("mlx5: increase RETA table size")

Signed-off-by: Yaacov Hazan <yaacovh@mellanox.com>
---
 drivers/net/mlx5/mlx5_defs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Adrien Mazarguil March 31, 2016, 9:36 a.m. UTC | #1 
On Thu, Mar 31, 2016 at 12:21:08PM +0300, Yaacov Hazan wrote:
> When the number of RX queues is not a power of two,
> the RETA table is configured to its maximum size for
> better balancing.
> 
> Testing showed that limiting its size to 256 improves performance
> noticeably with little to no  impact on balancing results.
> 
> Fixes: ebb30ec64a68 ("mlx5: increase RETA table size")
> 
> Signed-off-by: Yaacov Hazan <yaacovh@mellanox.com>

Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Thomas Monjalon March 31, 2016, 1 p.m. UTC | #2 
2016-03-31 11:36, Adrien Mazarguil:
> On Thu, Mar 31, 2016 at 12:21:08PM +0300, Yaacov Hazan wrote:
> > When the number of RX queues is not a power of two,
> > the RETA table is configured to its maximum size for
> > better balancing.
> > 
> > Testing showed that limiting its size to 256 improves performance
> > noticeably with little to no  impact on balancing results.
> > 
> > Fixes: ebb30ec64a68 ("mlx5: increase RETA table size")
> > 
> > Signed-off-by: Yaacov Hazan <yaacovh@mellanox.com>
> 
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

Applied, thanks
diff mbox

Patch

diff --git a/drivers/net/mlx5/mlx5_defs.h b/drivers/net/mlx5/mlx5_defs.h
index 195440c..09207d9 100644
--- a/drivers/net/mlx5/mlx5_defs.h
+++ b/drivers/net/mlx5/mlx5_defs.h
@@ -52,7 +52,7 @@ 
 #define MLX5_PMD_TX_PER_COMP_REQ 64
 
 /* RSS Indirection table size. */
-#define RSS_INDIRECTION_TABLE_SIZE 512
+#define RSS_INDIRECTION_TABLE_SIZE 256
 
 /* Maximum number of Scatter/Gather Elements per Work Request. */
 #ifndef MLX5_PMD_SGE_WR_N