diff mbox

[dpdk-dev] examples/ipsec-secgw: Fix Missed Headers For FreeBSD

Message ID 1459415578-3692-1-git-send-email-danielx.t.mrzyglod@intel.com (mailing list archive)
State Superseded, archived
Headers

Commit Message

Daniel Mrzyglod March 31, 2016, 9:12 a.m. UTC 
  There were misssed typedef for u_char - <sys/types.h>
There were missed network definitions - <netinet/in.h>

Failure #13: http://dpdk.org/ml/archives/test-report/2016-March/001896.html

Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application")

Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
---
 examples/ipsec-secgw/esp.c   | 4 +++-
 examples/ipsec-secgw/ipsec.c | 2 +-
 examples/ipsec-secgw/rt.c    | 1 +
 examples/ipsec-secgw/sa.c    | 2 ++
 examples/ipsec-secgw/sp.c    | 2 ++
 5 files changed, 9 insertions(+), 2 deletions(-)

Comments

Sergio Gonzalez Monroy March 31, 2016, 11:22 a.m. UTC | #1 
Commit title shouldn't contain capital letters.

On 31/03/2016 10:12, Daniel Mrzyglod wrote:
> There were misssed typedef for u_char - <sys/types.h>
> There were missed network definitions - <netinet/in.h>

Something a bit more descriptive along the lines of:
     In FreeBSD, sys/types.h and netinet/in.h need to be included before 
netinet/ip.h.
> Failure #13: http://dpdk.org/ml/archives/test-report/2016-March/001896.html
>
> Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application")
>
> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
> ---
>   examples/ipsec-secgw/esp.c   | 4 +++-
>   examples/ipsec-secgw/ipsec.c | 2 +-
>   examples/ipsec-secgw/rt.c    | 1 +
>   examples/ipsec-secgw/sa.c    | 2 ++
>   examples/ipsec-secgw/sp.c    | 2 ++
>   5 files changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/examples/ipsec-secgw/esp.c b/examples/ipsec-secgw/esp.c
> index ca0fc56..7b0e04c 100644
> --- a/examples/ipsec-secgw/esp.c
> +++ b/examples/ipsec-secgw/esp.c
> @@ -33,8 +33,10 @@
>   
>   #include <stdint.h>
>   #include <stdlib.h>
> -#include <netinet/ip.h>
>   #include <sys/types.h>
> +#include <sys/socket.h>

Do we need sys/socket.h?

Sergio
diff mbox

Patch

diff --git a/examples/ipsec-secgw/esp.c b/examples/ipsec-secgw/esp.c
index ca0fc56..7b0e04c 100644
--- a/examples/ipsec-secgw/esp.c
+++ b/examples/ipsec-secgw/esp.c
@@ -33,8 +33,10 @@ 
 
 #include <stdint.h>
 #include <stdlib.h>
-#include <netinet/ip.h>
 #include <sys/types.h>
+#include <sys/socket.h>
+#include <netinet/in.h>
+#include <netinet/ip.h>
 #include <sys/stat.h>
 #include <fcntl.h>
 #include <unistd.h>
diff --git a/examples/ipsec-secgw/ipsec.c b/examples/ipsec-secgw/ipsec.c
index d385100..baf30d4 100644
--- a/examples/ipsec-secgw/ipsec.c
+++ b/examples/ipsec-secgw/ipsec.c
@@ -30,7 +30,7 @@ 
  *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
-
+#include <sys/types.h>
 #include <netinet/in.h>
 #include <netinet/ip.h>
 
diff --git a/examples/ipsec-secgw/rt.c b/examples/ipsec-secgw/rt.c
index c3bb4de..a6d0866 100644
--- a/examples/ipsec-secgw/rt.c
+++ b/examples/ipsec-secgw/rt.c
@@ -34,6 +34,7 @@ 
 /*
  * Routing Table (RT)
  */
+#include <sys/types.h>
 #include <rte_lpm.h>
 #include <rte_errno.h>
 
diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c
index 91a5f6e..a5b8a63 100644
--- a/examples/ipsec-secgw/sa.c
+++ b/examples/ipsec-secgw/sa.c
@@ -34,6 +34,8 @@ 
 /*
  * Security Associations
  */
+#include <sys/types.h>
+#include <netinet/in.h>
 #include <netinet/ip.h>
 
 #include <rte_memzone.h>
diff --git a/examples/ipsec-secgw/sp.c b/examples/ipsec-secgw/sp.c
index 7972f40..4f16730 100644
--- a/examples/ipsec-secgw/sp.c
+++ b/examples/ipsec-secgw/sp.c
@@ -34,6 +34,8 @@ 
 /*
  * Security Policies
  */
+#include <sys/types.h>
+#include <netinet/in.h>
 #include <netinet/ip.h>
 
 #include <rte_acl.h>