diff mbox

[dpdk-dev] vmxnet3: remove asserts that confuse coverity

Message ID 1459373905-10296-1-git-send-email-stephen@networkplumber.org (mailing list archive)
State Accepted, archived
Headers

Commit Message

Stephen Hemminger March 30, 2016, 9:38 p.m. UTC 
  These asserts are only for debugging and never fired during
any testing, but they confuse coverity's null tracking.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/vmxnet3/vmxnet3_rxtx.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Yong Wang March 31, 2016, 5:50 p.m. UTC | #1 
On 3/30/16, 2:38 PM, "Stephen Hemminger" <stephen@networkplumber.org> wrote:



>These asserts are only for debugging and never fired during

>any testing, but they confuse coverity's null tracking.

>

>Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

>---


Acked-by: Yong Wang <yongwang@vmware.com>



> drivers/net/vmxnet3/vmxnet3_rxtx.c | 2 --

> 1 file changed, 2 deletions(-)

>

>diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c

>index 66b0eed..f72156a 100644

>--- a/drivers/net/vmxnet3/vmxnet3_rxtx.c

>+++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c

>@@ -710,7 +710,6 @@ vmxnet3_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)

> 		 * the last mbuf of the current packet.

> 		 */

> 		if (rcd->sop) {

>-			VMXNET3_ASSERT(rxq->start_seg != NULL);

> 			VMXNET3_ASSERT(rxd->btype == VMXNET3_RXD_BTYPE_HEAD);

> 

> 			if (unlikely(rcd->len == 0)) {

>@@ -729,7 +728,6 @@ vmxnet3_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)

> 			struct rte_mbuf *start = rxq->start_seg;

> 

> 			VMXNET3_ASSERT(rxd->btype == VMXNET3_RXD_BTYPE_BODY);

>-			VMXNET3_ASSERT(start != NULL);

> 

> 			start->pkt_len += rxm->data_len;

> 			start->nb_segs++;

>-- 

>2.1.4

>
Thomas Monjalon March 31, 2016, 7:18 p.m. UTC | #2 
> >These asserts are only for debugging and never fired during
> >any testing, but they confuse coverity's null tracking.
> >
> >Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> 
> Acked-by: Yong Wang <yongwang@vmware.com>

Applied, thanks
diff mbox

Patch

diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c
index 66b0eed..f72156a 100644
--- a/drivers/net/vmxnet3/vmxnet3_rxtx.c
+++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c
@@ -710,7 +710,6 @@  vmxnet3_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
 		 * the last mbuf of the current packet.
 		 */
 		if (rcd->sop) {
-			VMXNET3_ASSERT(rxq->start_seg != NULL);
 			VMXNET3_ASSERT(rxd->btype == VMXNET3_RXD_BTYPE_HEAD);
 
 			if (unlikely(rcd->len == 0)) {
@@ -729,7 +728,6 @@  vmxnet3_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
 			struct rte_mbuf *start = rxq->start_seg;
 
 			VMXNET3_ASSERT(rxd->btype == VMXNET3_RXD_BTYPE_BODY);
-			VMXNET3_ASSERT(start != NULL);
 
 			start->pkt_len += rxm->data_len;
 			start->nb_segs++;