diff mbox

[dpdk-dev,2/2] doc: update which PMDs can parse packet type

Message ID 1458875736-56444-3-git-send-email-jianfeng.tan@intel.com (mailing list archive)
State Changes Requested, archived
Headers

Commit Message

Jianfeng Tan March 25, 2016, 3:15 a.m. UTC 
  Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
---
 doc/guides/nics/overview.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bruce Richardson March 25, 2016, 2:21 p.m. UTC | #1 
On Fri, Mar 25, 2016 at 11:15:36AM +0800, Jianfeng Tan wrote:
> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
> ---
>  doc/guides/nics/overview.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/doc/guides/nics/overview.rst b/doc/guides/nics/overview.rst
> index 542479a..e7504da 100644
> --- a/doc/guides/nics/overview.rst
> +++ b/doc/guides/nics/overview.rst
> @@ -124,7 +124,7 @@ Most of these differences are summarized below.
>     L4 checksum offload          X   X   X   X
>     inner L3 checksum                X   X   X
>     inner L4 checksum                X   X   X
> -   packet type parsing          X       X   X
> +   packet type parsing  X X X X     X     X   X                     X   X X X X X X   X

This diff does not look right. How come some entries are being removed from some drivers?
Are you sure the line has correct whitespace on it?

/Bruce
Jianfeng Tan March 25, 2016, 4:10 p.m. UTC | #2 
Hi Bruce,

On 3/25/2016 10:21 PM, Bruce Richardson wrote:
> On Fri, Mar 25, 2016 at 11:15:36AM +0800, Jianfeng Tan wrote:
>> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
>> ---
>>   doc/guides/nics/overview.rst | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/doc/guides/nics/overview.rst b/doc/guides/nics/overview.rst
>> index 542479a..e7504da 100644
>> --- a/doc/guides/nics/overview.rst
>> +++ b/doc/guides/nics/overview.rst
>> @@ -124,7 +124,7 @@ Most of these differences are summarized below.
>>      L4 checksum offload          X   X   X   X
>>      inner L3 checksum                X   X   X
>>      inner L4 checksum                X   X   X
>> -   packet type parsing          X       X   X
>> +   packet type parsing  X X X X     X     X   X                     X   X X X X X X   X
> This diff does not look right. How come some entries are being removed from some drivers?
> Are you sure the line has correct whitespace on it?
>
> /Bruce

Thank you for checking this, actually I forget to rebase on rel_16_04. 
There's newly added vhost-pmd.

-   packet type parsing  X X X X     X     X   X X   X X X X X X   X
+   packet type parsing  X X X X     X     X   X X   X X X X X X X   X

Besides, I use thunderbird to see it, seems whilespace occupies less 
width than characters.

Thanks,
Jianfeng
Thomas Monjalon April 1, 2016, 3:55 p.m. UTC | #3 
2016-03-26 00:10, Tan, Jianfeng:
> On 3/25/2016 10:21 PM, Bruce Richardson wrote:
> > On Fri, Mar 25, 2016 at 11:15:36AM +0800, Jianfeng Tan wrote:
> >> --- a/doc/guides/nics/overview.rst
> >> +++ b/doc/guides/nics/overview.rst
> >> @@ -124,7 +124,7 @@ Most of these differences are summarized below.
> >>      L4 checksum offload          X   X   X   X
> >>      inner L3 checksum                X   X   X
> >>      inner L4 checksum                X   X   X
> >> -   packet type parsing          X       X   X
> >> +   packet type parsing  X X X X     X     X   X                     X   X X X X X X   X
> > This diff does not look right. How come some entries are being removed from some drivers?
> > Are you sure the line has correct whitespace on it?
> >
> > /Bruce
> 
> Thank you for checking this, actually I forget to rebase on rel_16_04. 
> There's newly added vhost-pmd.
> 
> -   packet type parsing  X X X X     X     X   X X   X X X X X X   X
> +   packet type parsing  X X X X     X     X   X X   X X X X X X X   X

Sorry I don't understand what you want to fill.
Please rebase and re-send.
diff mbox

Patch

diff --git a/doc/guides/nics/overview.rst b/doc/guides/nics/overview.rst
index 542479a..e7504da 100644
--- a/doc/guides/nics/overview.rst
+++ b/doc/guides/nics/overview.rst
@@ -124,7 +124,7 @@  Most of these differences are summarized below.
    L4 checksum offload          X   X   X   X
    inner L3 checksum                X   X   X
    inner L4 checksum                X   X   X
-   packet type parsing          X       X   X
+   packet type parsing  X X X X     X     X   X                     X   X X X X X X   X
    timesync                             X X
    basic stats                  X   X   X X X X                               X X
    extended stats                   X   X X X X