[dpdk-dev,v2] l2fwd-crypto: fix incorrect command line help
Commit Message
Previous cdev parameter was changed to cdev_type,
to select a crypto device type preference (HW/SW/ANY),
instead of the device itself (QAT/AESNI...).
Also deleted cdev duplicated parameter from the help.
Fixes: 27cf2d1b18e1 ("examples/l2fwd-crypto: discover capabilities")
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
---
Changes in v2:
- Removed duplicated parameter in command line help
examples/l2fwd-crypto/main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> Sent: Thursday, March 24, 2016 1:40 PM
> To: dev@dpdk.org
> Cc: Doherty, Declan; De Lara Guarch, Pablo
> Subject: [dpdk-dev] [PATCH v2] l2fwd-crypto: fix incorrect command line help
>
> Previous cdev parameter was changed to cdev_type, to select a crypto device
> type preference (HW/SW/ANY), instead of the device itself (QAT/AESNI...).
> Also deleted cdev duplicated parameter from the help.
>
> Fixes: 27cf2d1b18e1 ("examples/l2fwd-crypto: discover capabilities")
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>
> ---
>
> Changes in v2:
> - Removed duplicated parameter in command line help
>
> examples/l2fwd-crypto/main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
> > Previous cdev parameter was changed to cdev_type, to select a crypto device
> > type preference (HW/SW/ANY), instead of the device itself (QAT/AESNI...).
> > Also deleted cdev duplicated parameter from the help.
> >
> > Fixes: 27cf2d1b18e1 ("examples/l2fwd-crypto: discover capabilities")
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > Acked-by: Fiona Trahe <fiona.trahe@intel.com>
> > ---
> >
> > Changes in v2:
> > - Removed duplicated parameter in command line help
> >
> > examples/l2fwd-crypto/main.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>
Applied, thanks.
@@ -762,14 +762,14 @@ l2fwd_launch_one_lcore(void *arg)
static void
l2fwd_crypto_usage(const char *prgname)
{
- printf("%s [EAL options] -- --cdev TYPE [optional parameters]\n"
+ printf("%s [EAL options] --\n"
" -p PORTMASK: hexadecimal bitmask of ports to configure\n"
" -q NQ: number of queue (=ports) per lcore (default is 1)\n"
" -s manage all ports from single lcore"
" -t PERIOD: statistics will be refreshed each PERIOD seconds"
" (0 to disable, 10 default, 86400 maximum)\n"
- " --cdev AESNI_MB / QAT\n"
+ " --cdev_type HW / SW / ANY\n"
" --chain HASH_CIPHER / CIPHER_HASH\n"
" --cipher_algo ALGO\n"