[dpdk-dev] mk: restrict CPU flags list
Commit Message
When compiling each file, the CPU flags are given as RTE_MACHINE_CPUFLAG_*
and in the list RTE_COMPILE_TIME_CPUFLAGS.
RTE_MACHINE_CPUFLAG_* are used to check the CPU features when compiling.
The list RTE_COMPILE_TIME_CPUFLAGS is used only to check the CPU at
runtime in the function rte_cpu_check_supported(). So it is not needed to
define this list for every files.
That's why RTE_COMPILE_TIME_CPUFLAGS is removed from the common variable
MACHINE_CFLAGS and is added only to the CFLAGS of eal_common_cpuflags.c.
Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
lib/librte_eal/bsdapp/eal/Makefile | 2 ++
lib/librte_eal/linuxapp/eal/Makefile | 2 ++
mk/rte.cpuflags.mk | 2 +-
3 files changed, 5 insertions(+), 1 deletion(-)
Comments
2016-03-21 21:27, Thomas Monjalon:
> When compiling each file, the CPU flags are given as RTE_MACHINE_CPUFLAG_*
> and in the list RTE_COMPILE_TIME_CPUFLAGS.
>
> RTE_MACHINE_CPUFLAG_* are used to check the CPU features when compiling.
>
> The list RTE_COMPILE_TIME_CPUFLAGS is used only to check the CPU at
> runtime in the function rte_cpu_check_supported(). So it is not needed to
> define this list for every files.
> That's why RTE_COMPILE_TIME_CPUFLAGS is removed from the common variable
> MACHINE_CFLAGS and is added only to the CFLAGS of eal_common_cpuflags.c.
>
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
Applied
@@ -92,6 +92,8 @@ SRCS-$(CONFIG_RTE_EXEC_ENV_BSDAPP) += rte_keepalive.c
# from arch dir
SRCS-$(CONFIG_RTE_EXEC_ENV_BSDAPP) += rte_cpuflags.c
+CFLAGS_eal_common_cpuflags.o := $(CPUFLAGS_LIST)
+
CFLAGS_eal.o := -D_GNU_SOURCE
#CFLAGS_eal_thread.o := -D_GNU_SOURCE
CFLAGS_eal_log.o := -D_GNU_SOURCE
@@ -102,6 +102,8 @@ SRCS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += rte_keepalive.c
# from arch dir
SRCS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += rte_cpuflags.c
+CFLAGS_eal_common_cpuflags.o := $(CPUFLAGS_LIST)
+
CFLAGS_eal.o := -D_GNU_SOURCE
CFLAGS_eal_interrupts.o := -D_GNU_SOURCE
CFLAGS_eal_pci_vfio_mp_sync.o := -D_GNU_SOURCE
@@ -128,4 +128,4 @@ empty:=
space:= $(empty) $(empty)
CPUFLAGSTMP1 := $(addprefix RTE_CPUFLAG_,$(CPUFLAGS))
CPUFLAGSTMP2 := $(subst $(space),$(comma),$(CPUFLAGSTMP1))
-MACHINE_CFLAGS += -DRTE_COMPILE_TIME_CPUFLAGS=$(CPUFLAGSTMP2)
+CPUFLAGS_LIST := -DRTE_COMPILE_TIME_CPUFLAGS=$(CPUFLAGSTMP2)