[dpdk-dev] qat pmd:Fixing build issue on 32-bit systems
Commit Message
Fixing build issue on 32-bit systems.
Fixes: 1703e94ac5ce ("qat: add driver for QuickAssist devices")
Signed-off-by: John Griffin <john.griffin@intel.com>
---
drivers/crypto/qat/qat_crypto.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
Hi John,
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of John Griffin
> Sent: Tuesday, February 16, 2016 9:45 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] qat pmd:Fixing build issue on 32-bit systems
>
> Fixing build issue on 32-bit systems.
> Fixes: 1703e94ac5ce ("qat: add driver for QuickAssist devices")
>
> Signed-off-by: John Griffin <john.griffin@intel.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Could you include the error that you are fixing on this patch?
For example:
drivers/crypto/qat/qat_crypto.c:345:13:
error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
Also, as a general rule, patch titles start with lowercase and do not include the name "issue" if we use "fix".
e.g. (qat: fix build on 32-bit systems).
Apart from this, patch looks OK to me, so you can leave the acknowledgment in the v2.
Thanks!
Pablo
Hi Pablo,
Sure - will resubmit a v2 with those modifications.
Thanks,
John.
On 16/02/16 15:52, De Lara Guarch, Pablo wrote:
> Hi John,
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of John Griffin
>> Sent: Tuesday, February 16, 2016 9:45 AM
>> To: dev@dpdk.org
>> Subject: [dpdk-dev] [PATCH] qat pmd:Fixing build issue on 32-bit systems
>>
>> Fixing build issue on 32-bit systems.
>> Fixes: 1703e94ac5ce ("qat: add driver for QuickAssist devices")
>>
>> Signed-off-by: John Griffin <john.griffin@intel.com>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>
> Could you include the error that you are fixing on this patch?
>
> For example:
>
> drivers/crypto/qat/qat_crypto.c:345:13:
> error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
>
> Also, as a general rule, patch titles start with lowercase and do not include the name "issue" if we use "fix".
> e.g. (qat: fix build on 32-bit systems).
>
> Apart from this, patch looks OK to me, so you can leave the acknowledgment in the v2.
>
> Thanks!
> Pablo
>
@@ -342,7 +342,7 @@ qat_crypto_pkt_rx_burst(void *qp, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
while (*(uint32_t *)resp_msg != ADF_RING_EMPTY_SIG &&
msg_counter != nb_pkts) {
- rx_mbuf = (struct rte_mbuf *)(resp_msg->opaque_data);
+ rx_mbuf = (struct rte_mbuf *)(uintptr_t)(resp_msg->opaque_data);
ol = rte_pktmbuf_offload_get(rx_mbuf, RTE_PKTMBUF_OL_CRYPTO);
if (ICP_QAT_FW_COMN_STATUS_FLAG_OK !=
@@ -405,7 +405,7 @@ qat_alg_write_mbuf_entry(struct rte_mbuf *mbuf, uint8_t *out_msg)
ctx = (struct qat_session *)ol->op.crypto.session->_private;
qat_req = (struct icp_qat_fw_la_bulk_req *)out_msg;
*qat_req = ctx->fw_req;
- qat_req->comn_mid.opaque_data = (uint64_t)mbuf;
+ qat_req->comn_mid.opaque_data = (uint64_t)(uintptr_t)mbuf;
/*
* The following code assumes: