diff mbox

[dpdk-dev] nfp: fix non-x86 build

Message ID 1454795476-25542-1-git-send-email-thomas.monjalon@6wind.com (mailing list archive)
State Accepted, archived
Delegated to: Bruce Richardson
Headers

Commit Message

Thomas Monjalon Feb. 6, 2016, 9:51 p.m. UTC 
  The file sys/io.h was included but it can be unavailable in some
non-x86 toolchains.
As others system includes in the file nfp_net.c, it seems useless,
so the easy fix is to remove them.

Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
 drivers/net/nfp/nfp_net.c | 11 -----------
 1 file changed, 11 deletions(-)

Comments

Alejandro Lucero Feb. 8, 2016, 2:27 p.m. UTC | #1 
On Sat, Feb 6, 2016 at 9:51 PM, Thomas Monjalon <thomas.monjalon@6wind.com>
wrote:

> The file sys/io.h was included but it can be unavailable in some
> non-x86 toolchains.
> As others system includes in the file nfp_net.c, it seems useless,
> so the easy fix is to remove them.
>
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> ---
>  drivers/net/nfp/nfp_net.c | 11 -----------
>  1 file changed, 11 deletions(-)
>
> diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
> index bc2089f..283269e 100644
> --- a/drivers/net/nfp/nfp_net.c
> +++ b/drivers/net/nfp/nfp_net.c
> @@ -39,18 +39,7 @@
>   * Netronome vNIC DPDK Poll-Mode Driver: Main entry point
>   */
>
> -#include <stdio.h>
> -#include <stdlib.h>
> -#include <stdint.h>
> -#include <unistd.h>
> -#include <string.h>
> -#include <sys/mman.h>
> -#include <sys/socket.h>
> -#include <sys/io.h>
> -#include <assert.h>
> -#include <time.h>
>  #include <math.h>
> -#include <inttypes.h>
>
>  #include <rte_byteorder.h>
>  #include <rte_common.h>
> --
> 2.7.0
>
>
This is fine for me.

Thanks
Bruce Richardson March 2, 2016, 9:10 p.m. UTC | #2 
On Mon, Feb 08, 2016 at 02:27:59PM +0000, Alejandro Lucero wrote:
> On Sat, Feb 6, 2016 at 9:51 PM, Thomas Monjalon <thomas.monjalon@6wind.com>
> wrote:
> 
> > The file sys/io.h was included but it can be unavailable in some
> > non-x86 toolchains.
> > As others system includes in the file nfp_net.c, it seems useless,
> > so the easy fix is to remove them.
> >
> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> > ---
> >  drivers/net/nfp/nfp_net.c | 11 -----------
> >  1 file changed, 11 deletions(-)
> >
> > diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
> > index bc2089f..283269e 100644
> > --- a/drivers/net/nfp/nfp_net.c
> > +++ b/drivers/net/nfp/nfp_net.c
> > @@ -39,18 +39,7 @@
> >   * Netronome vNIC DPDK Poll-Mode Driver: Main entry point
> >   */
> >
> > -#include <stdio.h>
> > -#include <stdlib.h>
> > -#include <stdint.h>
> > -#include <unistd.h>
> > -#include <string.h>
> > -#include <sys/mman.h>
> > -#include <sys/socket.h>
> > -#include <sys/io.h>
> > -#include <assert.h>
> > -#include <time.h>
> >  #include <math.h>
> > -#include <inttypes.h>
> >
> >  #include <rte_byteorder.h>
> >  #include <rte_common.h>
> > --
> > 2.7.0
> >
> >
> This is fine for me.
> 
> Thanks

Applied to dpdk-next-net/rel_16_04 with Alejandro's ack

/Bruce
diff mbox

Patch

diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index bc2089f..283269e 100644
--- a/drivers/net/nfp/nfp_net.c
+++ b/drivers/net/nfp/nfp_net.c
@@ -39,18 +39,7 @@ 
  * Netronome vNIC DPDK Poll-Mode Driver: Main entry point
  */
 
-#include <stdio.h>
-#include <stdlib.h>
-#include <stdint.h>
-#include <unistd.h>
-#include <string.h>
-#include <sys/mman.h>
-#include <sys/socket.h>
-#include <sys/io.h>
-#include <assert.h>
-#include <time.h>
 #include <math.h>
-#include <inttypes.h>
 
 #include <rte_byteorder.h>
 #include <rte_common.h>