[dpdk-dev] eal: fix compile error in eal_timer.c caused by hpet

Message ID KL1PR0401MB1301A913A318D66496DC6299A4DA0@KL1PR0401MB1301.apcprd04.prod.outlook.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Commit Message

Yi Lu Jan. 28, 2016, 2:16 p.m. UTC
  Fix compile error when enable CONFIG_RTE_LIBEAL_USE_HPET.

Error messages:
/root/dpdk-2.2.0/lib/librte_eal/linuxapp/eal/eal_timer.c: In function ‘rte_eal_hpet_init’:
/root/dpdk-2.2.0/lib/librte_eal/linuxapp/eal/eal_timer.c:222:2: error: implicit declaration of function ‘rte_thread_setname’ [-Werror=implicit-function-declaration]
  ret = rte_thread_setname(msb_inc_thread_id, thread_name);
  ^
/root/dpdk-2.2.0/lib/librte_eal/linuxapp/eal/eal_timer.c:222:2: error: nested extern declaration of ‘rte_thread_setname’ [-Werror=nested-externs]
cc1: all warnings being treated as errors

Fixes: badb3688ffa8 ("eal/linux: fix build with glibc < 2.12")

Signed-off-by: Yi Lu <luyi68@live.com>

Acked-by: David Marchand <david.marchand@6wind.com>

---
 lib/librte_eal/linuxapp/eal/eal_timer.c | 1 +
 1 file changed, 1 insertion(+)

-- 
1.8.3.1
  

Comments

Thomas Monjalon March 2, 2016, 4:45 p.m. UTC | #1
2016-01-28 14:16, 卢 毅:
> Fix compile error when enable CONFIG_RTE_LIBEAL_USE_HPET.
> 
> Error messages:
> /root/dpdk-2.2.0/lib/librte_eal/linuxapp/eal/eal_timer.c: In function ‘rte_eal_hpet_init’:
> /root/dpdk-2.2.0/lib/librte_eal/linuxapp/eal/eal_timer.c:222:2: error: implicit declaration of function ‘rte_thread_setname’ [-Werror=implicit-function-declaration]
>   ret = rte_thread_setname(msb_inc_thread_id, thread_name);
>   ^
> /root/dpdk-2.2.0/lib/librte_eal/linuxapp/eal/eal_timer.c:222:2: error: nested extern declaration of ‘rte_thread_setname’ [-Werror=nested-externs]
> cc1: all warnings being treated as errors
> 
> Fixes: badb3688ffa8 ("eal/linux: fix build with glibc < 2.12")

Just looking at the first letters of this SHA1 gives a hint ;)

> Signed-off-by: Yi Lu <luyi68@live.com>
> Acked-by: David Marchand <david.marchand@6wind.com>

Applied, thanks
  

Patch

diff --git a/lib/librte_eal/linuxapp/eal/eal_timer.c b/lib/librte_eal/linuxapp/eal/eal_timer.c
index 9ceff33..bcadf09 100644
--- a/lib/librte_eal/linuxapp/eal/eal_timer.c
+++ b/lib/librte_eal/linuxapp/eal/eal_timer.c
@@ -50,6 +50,7 @@ 
 #include <rte_memory.h>
 #include <rte_memzone.h>
 #include <rte_eal.h>
+#include <rte_lcore.h>
 #include <rte_debug.h>
 
 #include "eal_private.h"