diff mbox

[dpdk-dev] ethdev: remove the imissed deprecation tag

Message ID 1443601256-181129-1-git-send-email-maryam.tahhan@intel.com (mailing list archive)
State Superseded, archived
Headers

Commit Message

Tahhan, Maryam Sept. 30, 2015, 8:20 a.m. UTC 
  Remove the deprecation tag and notice for imissed.

Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
---
 doc/guides/rel_notes/deprecation.rst | 2 +-
 lib/librte_ether/rte_ethdev.h        | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

Comments

Olivier Matz Oct. 13, 2015, 1:57 p.m. UTC | #1 
Hi Maryam,

On 09/30/2015 10:20 AM, Maryam Tahhan wrote:
> Remove the deprecation tag and notice for imissed.
> 
> Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 2 +-
>  lib/librte_ether/rte_ethdev.h        | 3 +--
>  2 files changed, 2 insertions(+), 3 deletions(-)

Could you please add some more details about why it is finally
kept? I think it could be helpful for people that did not follow
the thread http://dpdk.org/dev/patchwork/patch/6410/

You can also reference the commit id of the patch that
introduced the deprecation notice.

It could also be a good occasion to remind the definition of
imissed: number of packets dropped by hardware because the software
does not poll fast enough (= queue full)

Thanks!
Olivier
Stephen Hemminger Oct. 13, 2015, 3:53 p.m. UTC | #2 
On Wed, 30 Sep 2015 09:20:56 +0100
Maryam Tahhan <maryam.tahhan@intel.com> wrote:

> diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
> index fa06554..78bd94d 100644
> --- a/lib/librte_ether/rte_ethdev.h
> +++ b/lib/librte_ether/rte_ethdev.h
> @@ -194,8 +194,7 @@ struct rte_eth_stats {
>  	uint64_t opackets;  /**< Total number of successfully transmitted packets.*/
>  	uint64_t ibytes;    /**< Total number of successfully received bytes. */
>  	uint64_t obytes;    /**< Total number of successfully transmitted bytes. */
> -	uint64_t imissed;
> -	/**< Deprecated; Total of RX missed packets (e.g full FIFO). */

If you want to deprecate a structure field, it works better to mark
it with __attribute__((deprecated)) that way all use of that field in
code will be flagged.

Comments are advisory only and often never spotted.
diff mbox

Patch

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index fffad80..6e899f4 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -14,7 +14,7 @@  Deprecation Notices
   All binaries will need to be rebuilt from release 2.2.
 
 * The following fields have been deprecated in rte_eth_stats:
-  imissed, ibadcrc, ibadlen, imcasts, fdirmatch, fdirmiss,
+  ibadcrc, ibadlen, imcasts, fdirmatch, fdirmiss,
   tx_pause_xon, rx_pause_xon, tx_pause_xoff, rx_pause_xoff
 
 * API for flow director filters has been replaced by rte_eth_dev_filter_ctrl.
diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
index fa06554..78bd94d 100644
--- a/lib/librte_ether/rte_ethdev.h
+++ b/lib/librte_ether/rte_ethdev.h
@@ -194,8 +194,7 @@  struct rte_eth_stats {
 	uint64_t opackets;  /**< Total number of successfully transmitted packets.*/
 	uint64_t ibytes;    /**< Total number of successfully received bytes. */
 	uint64_t obytes;    /**< Total number of successfully transmitted bytes. */
-	uint64_t imissed;
-	/**< Deprecated; Total of RX missed packets (e.g full FIFO). */
+	uint64_t imissed;   /**< Total of RX missed packets (e.g full FIFO). */
 	uint64_t ibadcrc;
 	/**< Deprecated; Total of RX packets with CRC error. */
 	uint64_t ibadlen;