diff mbox

[dpdk-dev,v2,5/5] doc: modify release notes and deprecation notice for table and pipeline

Message ID 1441967499-21255-6-git-send-email-maciejx.t.gajdzica@intel.com (mailing list archive)
State Superseded, archived
Headers

Commit Message

Maciej Gajdzica Sept. 11, 2015, 10:31 a.m. UTC 
  The LIBABIVER number is incremented for table and pipeline libraries.
The release notes is updated and the deprecation announce is removed.

Signed-off-by: Maciej Gajdzica <maciejx.t.gajdzica@intel.com>
---
 doc/guides/rel_notes/deprecation.rst         |    3 ---
 doc/guides/rel_notes/release_2_2.rst         |    6 ++++--
 lib/librte_pipeline/Makefile                 |    2 +-
 lib/librte_pipeline/rte_pipeline_version.map |    8 ++++++++
 lib/librte_table/Makefile                    |    2 +-
 5 files changed, 14 insertions(+), 7 deletions(-)

Comments

Thomas Monjalon Oct. 8, 2015, 11:42 a.m. UTC | #1 
Hi Maciej,

2015-09-11 12:31, Maciej Gajdzica:
> The LIBABIVER number is incremented for table and pipeline libraries.
> The release notes is updated and the deprecation announce is removed.
[...]
> --- a/lib/librte_pipeline/rte_pipeline_version.map
> +++ b/lib/librte_pipeline/rte_pipeline_version.map
> @@ -29,3 +29,11 @@ DPDK_2.1 {
>  	rte_pipeline_table_stats_read;
>  
>  } DPDK_2.0;
> +
> +DPDK_2.2 {
> +	global:
> +
> +	rte_pipeline_table_entry_add_bulk;
> +	rte_pipeline_table_entry_delete_bulk;
> +
> +} DPDK_2.1;

The previous block was DPDK_2.0 for this library.
So I think you should inherit from it, not DPDK_2.1 which doesn't exist
in this context.
Piotr Azarewicz Oct. 12, 2015, 7:53 a.m. UTC | #2 
Hi Thomas,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Thursday, October 8, 2015 1:42 PM
> To: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 5/5] doc: modify release notes and
> deprecation notice for table and pipeline
> 
> Hi Maciej,
> 
> 2015-09-11 12:31, Maciej Gajdzica:
> > The LIBABIVER number is incremented for table and pipeline libraries.
> > The release notes is updated and the deprecation announce is removed.
> [...]
> > --- a/lib/librte_pipeline/rte_pipeline_version.map
> > +++ b/lib/librte_pipeline/rte_pipeline_version.map
> > @@ -29,3 +29,11 @@ DPDK_2.1 {
> >  	rte_pipeline_table_stats_read;
> >
> >  } DPDK_2.0;
> > +
> > +DPDK_2.2 {
> > +	global:
> > +
> > +	rte_pipeline_table_entry_add_bulk;
> > +	rte_pipeline_table_entry_delete_bulk;
> > +
> > +} DPDK_2.1;
> 
> The previous block was DPDK_2.0 for this library.
> So I think you should inherit from it, not DPDK_2.1 which doesn't exist in this
> context.

The previous block was DPDK_2.1 :

DPDK_2.1 {
	global:

	rte_pipeline_port_in_stats_read;
	rte_pipeline_port_out_stats_read;
	rte_pipeline_table_stats_read;

} DPDK_2.0;

So I think this patch is okay.
Correct me if I am wrong with my understanding, please.

Thanks,
Piotr
Thomas Monjalon Oct. 12, 2015, 8:22 a.m. UTC | #3 
2015-10-12 07:53, Azarewicz, PiotrX T:
> Hi Thomas,
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> > Hi Maciej,
> > 
> > 2015-09-11 12:31, Maciej Gajdzica:
> > > --- a/lib/librte_pipeline/rte_pipeline_version.map
> > > +++ b/lib/librte_pipeline/rte_pipeline_version.map
> > > @@ -29,3 +29,11 @@ DPDK_2.1 {
> > >  	rte_pipeline_table_stats_read;
> > >
> > >  } DPDK_2.0;
> > > +
> > > +DPDK_2.2 {
> > > +	global:
> > > +
> > > +	rte_pipeline_table_entry_add_bulk;
> > > +	rte_pipeline_table_entry_delete_bulk;
> > > +
> > > +} DPDK_2.1;
> > 
> > The previous block was DPDK_2.0 for this library.
> > So I think you should inherit from it, not DPDK_2.1 which doesn't exist in this
> > context.
> 
> The previous block was DPDK_2.1 :
> 
> DPDK_2.1 {
> 	global:
> 
> 	rte_pipeline_port_in_stats_read;
> 	rte_pipeline_port_out_stats_read;
> 	rte_pipeline_table_stats_read;
> 
> } DPDK_2.0;
> 
> So I think this patch is okay.
> Correct me if I am wrong with my understanding, please.

You are perfectly right.
Sorry for the confusion.
Piotr Azarewicz Oct. 12, 2015, 8:27 a.m. UTC | #4 
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Monday, October 12, 2015 10:23 AM
> To: Azarewicz, PiotrX T
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 5/5] doc: modify release notes and
> deprecation notice for table and pipeline
> 
> 2015-10-12 07:53, Azarewicz, PiotrX T:
> > Hi Thomas,
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> > > Hi Maciej,
> > >
> > > 2015-09-11 12:31, Maciej Gajdzica:
> > > > --- a/lib/librte_pipeline/rte_pipeline_version.map
> > > > +++ b/lib/librte_pipeline/rte_pipeline_version.map
> > > > @@ -29,3 +29,11 @@ DPDK_2.1 {
> > > >  	rte_pipeline_table_stats_read;
> > > >
> > > >  } DPDK_2.0;
> > > > +
> > > > +DPDK_2.2 {
> > > > +	global:
> > > > +
> > > > +	rte_pipeline_table_entry_add_bulk;
> > > > +	rte_pipeline_table_entry_delete_bulk;
> > > > +
> > > > +} DPDK_2.1;
> > >
> > > The previous block was DPDK_2.0 for this library.
> > > So I think you should inherit from it, not DPDK_2.1 which doesn't
> > > exist in this context.
> >
> > The previous block was DPDK_2.1 :
> >
> > DPDK_2.1 {
> > 	global:
> >
> > 	rte_pipeline_port_in_stats_read;
> > 	rte_pipeline_port_out_stats_read;
> > 	rte_pipeline_table_stats_read;
> >
> > } DPDK_2.0;
> >
> > So I think this patch is okay.
> > Correct me if I am wrong with my understanding, please.
> 
> You are perfectly right.
> Sorry for the confusion.

No problem, thank for the answer.
Piotr
diff mbox

Patch

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index fffad80..5f46cf9 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -60,9 +60,6 @@  Deprecation Notices
 * librte_table LPM: A new parameter to hold the table name will be added to
   the LPM table parameter structure.
 
-* librte_table: New functions for table entry bulk add/delete will be added
-  to the table operations structure.
-
 * librte_table hash: Key mask parameter will be added to the hash table
   parameter structure for 8-byte key and 16-byte key extendible bucket and
   LRU tables.
diff --git a/doc/guides/rel_notes/release_2_2.rst b/doc/guides/rel_notes/release_2_2.rst
index 682f468..deb8e4e 100644
--- a/doc/guides/rel_notes/release_2_2.rst
+++ b/doc/guides/rel_notes/release_2_2.rst
@@ -47,6 +47,8 @@  ABI Changes
 
 * The LPM structure is changed. The deprecated field mem_location is removed.
 
+* Added functions add/delete bulk to table and pipeline libraries.
+
 
 Shared Library Versions
 -----------------------
@@ -71,7 +73,7 @@  The libraries prepended with a plus sign were incremented in this version.
    + librte_mbuf.so.2
      librte_mempool.so.1
      librte_meter.so.1
-     librte_pipeline.so.1
+   + librte_pipeline.so.2
      librte_pmd_bond.so.1
    + librte_pmd_ring.so.2
      librte_port.so.1
@@ -79,6 +81,6 @@  The libraries prepended with a plus sign were incremented in this version.
      librte_reorder.so.1
      librte_ring.so.1
      librte_sched.so.1
-     librte_table.so.1
+   + librte_table.so.2
      librte_timer.so.1
      librte_vhost.so.1
diff --git a/lib/librte_pipeline/Makefile b/lib/librte_pipeline/Makefile
index 15e406b..1166d3c 100644
--- a/lib/librte_pipeline/Makefile
+++ b/lib/librte_pipeline/Makefile
@@ -41,7 +41,7 @@  CFLAGS += $(WERROR_FLAGS)
 
 EXPORT_MAP := rte_pipeline_version.map
 
-LIBABIVER := 1
+LIBABIVER := 2
 
 #
 # all source are stored in SRCS-y
diff --git a/lib/librte_pipeline/rte_pipeline_version.map b/lib/librte_pipeline/rte_pipeline_version.map
index 8f25d0f..5150070 100644
--- a/lib/librte_pipeline/rte_pipeline_version.map
+++ b/lib/librte_pipeline/rte_pipeline_version.map
@@ -29,3 +29,11 @@  DPDK_2.1 {
 	rte_pipeline_table_stats_read;
 
 } DPDK_2.0;
+
+DPDK_2.2 {
+	global:
+
+	rte_pipeline_table_entry_add_bulk;
+	rte_pipeline_table_entry_delete_bulk;
+
+} DPDK_2.1;
\ No newline at end of file
diff --git a/lib/librte_table/Makefile b/lib/librte_table/Makefile
index c5b3eaf..7f02af3 100644
--- a/lib/librte_table/Makefile
+++ b/lib/librte_table/Makefile
@@ -41,7 +41,7 @@  CFLAGS += $(WERROR_FLAGS)
 
 EXPORT_MAP := rte_table_version.map
 
-LIBABIVER := 1
+LIBABIVER := 2
 
 #
 # all source are stored in SRCS-y