Message ID | BN3PR03MB14318E1B7740E6ADDC2EF85DB3C50@BN3PR03MB1431.namprd03.prod.outlook.com (mailing list archive) |
---|---|
State | Not Applicable, archived |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 9513D68CF; Tue, 4 Oct 2016 21:31:31 +0200 (CEST) Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0049.outbound.protection.outlook.com [104.47.34.49]) by dpdk.org (Postfix) with ESMTP id 8AF4F68CA for <dev@dpdk.org>; Tue, 4 Oct 2016 21:31:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=SonusNetworks.onmicrosoft.com; s=selector1-sonusnet-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=JlpqRH2TSFan/T8sG1xLeehawsZF/0KrzTOFqQg8AdM=; b=EL0UDABxT7OaqiFu/PdhccqxgIpxM4201o4ga3HCRihphUfuu+I5HUlaomxiT/1SQdAhRVkmpQfJSnel7u6k/s0XmPaQfhSssrybJDCBYoXO2yg2zNrEytyzjdaOlpgXxfBFGK8sDKpd1Su8c3Q1xjVmPAF0eSn/zHxvxKGMPZc= Received: from BN3PR03MB1431.namprd03.prod.outlook.com (10.163.34.26) by BN3PR03MB1431.namprd03.prod.outlook.com (10.163.34.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.649.16; Tue, 4 Oct 2016 19:31:27 +0000 Received: from BN3PR03MB1431.namprd03.prod.outlook.com ([10.163.34.26]) by BN3PR03MB1431.namprd03.prod.outlook.com ([10.163.34.26]) with mapi id 15.01.0649.021; Tue, 4 Oct 2016 19:31:27 +0000 From: Karmarkar Suyash <skarmarkar@sonusnet.com> To: "dev@dpdk.org" <dev@dpdk.org>, "thomas.monjalon@6wind.com" <thomas.monjalon@6wind.com>, "rsanford@akamai.com" <rsanford@akamai.com>, "reshma.pattan@intel.com" <reshma.pattan@intel.com> Thread-Topic: [PATCH v2]:rte_timer:timer lag issue correction Thread-Index: AQHSEDPB2NrTgxc9oUadR+nlImJRw6CENQnwgAA/PYCADCZJ4IAIMEQQ Date: Tue, 4 Oct 2016 19:31:27 +0000 Message-ID: <BN3PR03MB14318E1B7740E6ADDC2EF85DB3C50@BN3PR03MB1431.namprd03.prod.outlook.com> References: <BN3PR03MB14310D01FAADE08B3E1EE384B3F60@BN3PR03MB1431.namprd03.prod.outlook.com> <20160921205427.14116-1-skarmarkar@sonusnet.com> <BN3PR03MB14312FD1C71886E4A3AC4A25B3CE0@BN3PR03MB1431.namprd03.prod.outlook.com> In-Reply-To: <BN3PR03MB14312FD1C71886E4A3AC4A25B3CE0@BN3PR03MB1431.namprd03.prod.outlook.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=skarmarkar@sonusnet.com; x-originating-ip: [208.45.178.4] x-ms-office365-filtering-correlation-id: 419a96b9-79af-4b74-2c34-08d3ec8d08fc x-microsoft-exchange-diagnostics: 1; BN3PR03MB1431; 6:MwwAQtGJmQHwZDgCWXyoWBc3dn0rgGVfn9OySI9/iaymm3o3wa09qSYdiPojymoww/AkhemJoDKKuf0a26ZHuDXiEYWmNkB1M6iP/krV/2VQBgXDTzGzTRLh1+THzuJi4u8IGSPY+DoiG7WR9e3GOALozIdlKEvQYvQzWrAPZDmkT0qZ5vFBpLvPYkzXClHLOL3M2/kYxQ/76A/WEOPDWNgx/xUE8zOP5x2ETO2PwnFeuBq+XKISWoIzmx7rYheumMZECGL/dw+6wo5dwC01P6QR2twnXXnCxBZP4yeAA3+YiUXQE0tXHofC3jKwU98h; 5:rfOedL2AOor0DzBC+w7xxEx24F5MTUvJqaDQCJ0KA1hwKijl+RloKcOLvENOnYMUvK7SVReMYp0qhvN6u2anOBnukTaKaPUkw3kdsRTlSoAh7LA+TKNwv885+DZrAlow/hr7ey8U/g83jgRLKiOH/SJ+OYVcTIdl1MFvRZsB/PQ=; 24:jwqxD2GOAx2pvdhthQ9aS5/m0Jw6Q5jPJV0uSwqrvx04sj+LwjTcpuWTx9YGhqpDvrZkSMsPY38lB5zvxJQD4xn223TeyZ9ukC+8cLB7qws=; 7:cgak9bKo6yCGHRuY26+FOb7WPyjfvaIKWwbTb8FucpBtEpEfon971OC+QYJrIK99NXuD8fDm+s32Ph2QhSDr5KnAvV7+rbfjwJGT4ik/SZUlKh90uDU71SQ3IZXYPdTJaukHPvJQwHX3xwLmNj7U4elHDJXm9vxaRpPBksMwZwjsSbCX+Qx2b6f54wJlOWt3+tbdi+61vckwEfFaZHZmdx5iRqzVzJKtLP8+wrGhVnwmXwZzwzb2CGpp3onQu78DxtFT+8uTRq+TJ/A37VZ8MucLIvcciCQizKHPXx64BZwtC8BOyuhiN+l9x/PHwMcy+sHs5jMlc+waNPtAWCyeeA== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1431; x-microsoft-antispam-prvs: <BN3PR03MB1431868F518D839CE6AE879DB3C50@BN3PR03MB1431.namprd03.prod.outlook.com> x-exchange-antispam-report-test: UriScan:(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046); SRVR:BN3PR03MB1431; BCL:0; PCL:0; RULEID:; SRVR:BN3PR03MB1431; x-forefront-prvs: 00851CA28B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(7916002)(13464003)(199003)(189002)(377454003)(305945005)(8676002)(7846002)(81156014)(7736002)(105586002)(101416001)(7696004)(3660700001)(11100500001)(3900700001)(3280700002)(77096005)(189998001)(122556002)(33656002)(74316002)(5660300001)(68736007)(106356001)(2501003)(99286002)(50986999)(76176999)(54356999)(106116001)(19580395003)(8936002)(107886002)(97736004)(66066001)(2906002)(2900100001)(2950100002)(2201001)(87936001)(76576001)(9686002)(19580405001)(3846002)(86362001)(10400500002)(102836003)(6116002)(5002640100001)(586003)(92566002)(5001770100001)(81166006); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR03MB1431; H:BN3PR03MB1431.namprd03.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: sonusnet.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: sonusnet.com X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Oct 2016 19:31:27.4039 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 29a671dc-ed7e-4a54-b1e5-8da1eb495dc3 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB1431 Subject: Re: [dpdk-dev] [PATCH v2]:rte_timer:timer lag issue correction X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
Karmarkar Suyash
Oct. 4, 2016, 7:31 p.m. UTC
Hello Robert/Thomas, Can you please review the changes in V2 of the Patch and suggest next steps? Thanks Regards Suyash Karmarkar -----Original Message----- From: Karmarkar Suyash Sent: Thursday, September 29, 2016 10:27 AM To: dev@dpdk.org; thomas.monjalon@6wind.com; rsanford@akamai.com; reshma.pattan@intel.com Subject: RE: [PATCH v2]:rte_timer:timer lag issue correction Hello, Can you please review the changes and suggest next steps? Thanks Regards Suyash Karmarkar -----Original Message----- From: Karmarkar Suyash Sent: Wednesday, September 21, 2016 4:54 PM To: dev@dpdk.org; thomas.monjalon@6wind.com; rsanford@akamai.com; reshma.pattan@intel.com Cc: Karmarkar Suyash <skarmarkar@sonusnet.com> Subject: [PATCH v2]:rte_timer:timer lag issue correction For Periodic timers ,if the lag gets introduced, the current code added additional delay when the next peridoc timer was initialized by not taking into account the delay added, with this fix the code would start the next occurrence of timer keeping in account the lag added.Corrected the behavior. Fixes: 9b15ba89 ("timer: use a skip list") Karmarkar Suyash (1): Signed-off-by: Karmarkar Suyash <skarmarkar@sonusnet.com> lib/librte_timer/rte_timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- lib/librte_timer/rte_timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.9.3.windows.1
diff --git a/lib/librte_timer/rte_timer.c b/lib/librte_timer/rte_timer.c index 43da836..18782fa 100644 --- a/lib/librte_timer/rte_timer.c +++ b/lib/librte_timer/rte_timer.c @@ -613,7 +613,7 @@ void rte_timer_manage(void) status.owner = (int16_t)lcore_id; rte_wmb(); tim->status.u32 = status.u32; - __rte_timer_reset(tim, cur_time + tim->period, + __rte_timer_reset(tim, tim->expire + tim->period, tim->period, lcore_id, tim->f, tim->arg, 1); rte_spinlock_unlock(&priv_timer[lcore_id].list_lock); }