Message ID | 1475113270-21983-1-git-send-email-zhouyates@gmail.com (mailing list archive) |
---|---|
State | Accepted, archived |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 427BD5597; Thu, 29 Sep 2016 03:40:57 +0200 (CEST) Received: from mail-pa0-f67.google.com (mail-pa0-f67.google.com [209.85.220.67]) by dpdk.org (Postfix) with ESMTP id DB6672BA1 for <dev@dpdk.org>; Thu, 29 Sep 2016 03:40:55 +0200 (CEST) Received: by mail-pa0-f67.google.com with SMTP id r9so2055997paz.1 for <dev@dpdk.org>; Wed, 28 Sep 2016 18:40:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=QxnhiRTNuki6pJCMLz35U/QzJqsJaJ9bVxmjbNwGVPA=; b=XP7ipQam1iTy9D/93pTRTCozUgTy7u7XBBemnfK5JYY2JiGGBYfr29fY5eRfL8QuMF 4DvnAOBtgOvaS+/gVODMa3aFF0HNpm9f+9HvJxc/32IEAmn41mapwrmkZZNU9DVOS959 CF148158Mkp27DXNPALX7IgihX7wESXMofdo6OcM7dWK1157oaFyRj8SohQTsDYTVoE3 2RRZ4i6unpJmHOkM7vXbC/4en2X7ymOH6bcaLAsglxki53Jc47TioAs/Qnn7WjHibyiV fptmFNUUHSi3P6LkIN/xHUtZtMzHzeytykItMoFaNV4oyUhsJCPhvtsIGqlZyEJJnkg+ lBLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=QxnhiRTNuki6pJCMLz35U/QzJqsJaJ9bVxmjbNwGVPA=; b=i8+oKwkxjO3UsLFO15gFolCyw96vL4NeldWo+QM2jC0W3suLV5qkwo5JcExqIaJ+tT E78R4pb6HevbssofpuBhcAO/yS78Izuz6Y16H0q15tQJ/t4rSFsaCGVo/X5mXFyR8Y5i pQ4j88O50GMVSqPriWvFID9B2pVXdwFi+EVqYVUeqsPexL/1e+/MBmY5HrNozZGv+y0g oDAL8KWpm0SUsr29elc0zupG60eIfM0JrEWkVMVC2D3lxSUT2Wy3MLE8uVGAV0u8zvGO 8VQK6mKwhLSxv7vpX4VpBGQ9fOi0fKLZnHezJq5awTKG4QgUXgSMFh4FaxObUcy/aytW eGAQ== X-Gm-Message-State: AA6/9RlPJ0eHKLNJKM2uAI+Nv+MjycZlWW/wsrshgssbNm09Jv5BPDAEmW3Sbzr0Myhjkw== X-Received: by 10.66.183.207 with SMTP id eo15mr4845007pac.128.1475113255288; Wed, 28 Sep 2016 18:40:55 -0700 (PDT) Received: from localhost.localdomain ([211.157.188.187]) by smtp.gmail.com with ESMTPSA id r88sm1014285pfi.51.2016.09.28.18.40.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Sep 2016 18:40:54 -0700 (PDT) From: Yangchao Zhou <zhouyates@gmail.com> To: thomas.monjalon@6wind.com Cc: dev@dpdk.org, david.marchand@6wind.com, Yangchao Zhou <zhouyates@gmail.com> Date: Thu, 29 Sep 2016 09:41:10 +0800 Message-Id: <1475113270-21983-1-git-send-email-zhouyates@gmail.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <4622854.nVE6J4R6pe@xps13> References: <4622854.nVE6J4R6pe@xps13> Subject: [dpdk-dev] [PATCH] pci:fix missing free X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
Matt
Sept. 29, 2016, 1:41 a.m. UTC
Signed-off-by: Yangchao Zhou <zhouyates@gmail.com>
---
lib/librte_eal/common/eal_common_pci.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
Comments
Hello, On Thu, Sep 29, 2016 at 3:41 AM, Yangchao Zhou <zhouyates@gmail.com> wrote: > Signed-off-by: Yangchao Zhou <zhouyates@gmail.com> > --- > lib/librte_eal/common/eal_common_pci.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c > index 7248c38..eb44998 100644 > --- a/lib/librte_eal/common/eal_common_pci.c > +++ b/lib/librte_eal/common/eal_common_pci.c > @@ -378,6 +378,7 @@ rte_eal_pci_detach(const struct rte_pci_addr *addr) > goto err_return; > > TAILQ_REMOVE(&pci_device_list, dev, next); > + free(dev); > return 0; > } > return -1; > -- > 1.7.1 > For the title, how about: pci: fix memory leak when detaching devices Afaics the fixes tag would be : Fixes: dbe6b4b61b0e ("pci: probe or close device") + CC stable
On Fri, Sep 30, 2016 at 5:19 PM, David Marchand <david.marchand@6wind.com> wrote: > Hello, > > On Thu, Sep 29, 2016 at 3:41 AM, Yangchao Zhou <zhouyates@gmail.com> wrote: >> Signed-off-by: Yangchao Zhou <zhouyates@gmail.com> >> --- >> lib/librte_eal/common/eal_common_pci.c | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c >> index 7248c38..eb44998 100644 >> --- a/lib/librte_eal/common/eal_common_pci.c >> +++ b/lib/librte_eal/common/eal_common_pci.c >> @@ -378,6 +378,7 @@ rte_eal_pci_detach(const struct rte_pci_addr *addr) >> goto err_return; >> >> TAILQ_REMOVE(&pci_device_list, dev, next); >> + free(dev); >> return 0; >> } >> return -1; >> -- >> 1.7.1 >> > > For the title, how about: > pci: fix memory leak when detaching devices > > Afaics the fixes tag would be : > > Fixes: dbe6b4b61b0e ("pci: probe or close device") > > + CC stable Thomas, can you apply this with my ack ? Thanks.
2016-09-30 17:27, David Marchand: > On Fri, Sep 30, 2016 at 5:19 PM, David Marchand > <david.marchand@6wind.com> wrote: > > Hello, > > > > On Thu, Sep 29, 2016 at 3:41 AM, Yangchao Zhou <zhouyates@gmail.com> wrote: > >> Signed-off-by: Yangchao Zhou <zhouyates@gmail.com> > > > > For the title, how about: > > pci: fix memory leak when detaching devices > > > > Afaics the fixes tag would be : > > > > Fixes: dbe6b4b61b0e ("pci: probe or close device") > > > > + CC stable > > Thomas, can you apply this with my ack ? > Thanks. Applied, thanks
diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c index 7248c38..eb44998 100644 --- a/lib/librte_eal/common/eal_common_pci.c +++ b/lib/librte_eal/common/eal_common_pci.c @@ -378,6 +378,7 @@ rte_eal_pci_detach(const struct rte_pci_addr *addr) goto err_return; TAILQ_REMOVE(&pci_device_list, dev, next); + free(dev); return 0; } return -1;