[dpdk-dev,1/1] doc: clarify usage of testpmd mac fwd mode

Message ID 1473437752-63371-1-git-send-email-mark.b.kavanagh@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Commit Message

Mark Kavanagh Sept. 9, 2016, 4:15 p.m. UTC
  Explain default testpmd behavior in mac fwd mode to remove
amiguity/confusion regarding user's ability to specify Ethernet
addresses.

Signed-off-by: Mark Kavanagh <mark.b.kavanagh@intel.com>
---
 doc/guides/testpmd_app_ug/testpmd_funcs.rst | 3 +++
 1 file changed, 3 insertions(+)
  

Comments

John McNamara Sept. 26, 2016, 12:24 p.m. UTC | #1
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Mark Kavanagh
> Sent: Friday, September 9, 2016 5:16 PM
> To: dev@dpdk.org
> Cc: Kavanagh, Mark B <mark.b.kavanagh@intel.com>
> Subject: [dpdk-dev] [PATCH 1/1] doc: clarify usage of testpmd mac fwd mode
> 
> Explain default testpmd behavior in mac fwd mode to remove
> amiguity/confusion regarding user's ability to specify Ethernet addresses.
> 
> Signed-off-by: Mark Kavanagh <mark.b.kavanagh@intel.com>

Acked-by: John McNamara <john.mcnamara@intel.com>
  
Thomas Monjalon Oct. 13, 2016, 4:12 p.m. UTC | #2
> > Explain default testpmd behavior in mac fwd mode to remove
> > amiguity/confusion regarding user's ability to specify Ethernet addresses.
> > 
> > Signed-off-by: Mark Kavanagh <mark.b.kavanagh@intel.com>
> 
> Acked-by: John McNamara <john.mcnamara@intel.com>

Applied, thanks
  

Patch

diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
index f87e0c2..6ab910e 100644
--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
@@ -267,6 +267,9 @@  The available information categories are:
   This is the default mode.
 
 * ``mac``: Changes the source and the destination Ethernet addresses of packets before forwarding them.
+  Default application behaviour is to set source Ethernet address to that of the transmitting interface, and destination
+  address to a dummy value (set during init). The user may specify a target destination Ethernet address via the 'eth-peer' or
+  'eth-peer-configfile' command-line options. It is not currently possible to specify a specific source Ethernet address.
 
 * ``macswap``: MAC swap forwarding mode.
   Swaps the source and the destination Ethernet addresses of packets before forwarding them.